Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency express to ~4.20.0 [security] #1993

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 29, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) ~4.18.3 -> ~4.20.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with [email protected], we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location

CVE-2024-43796

Impact

In express <4.20.0, passing untrusted user input - even after sanitizing it - to response.redirect() may execute untrusted code

Patches

this issue is patched in express 4.20.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

  1. The attacker MUST control the input to response.redirect()
  2. express MUST NOT redirect before the template appears
  3. the browser MUST NOT complete redirection before:
  4. the user MUST click on the link in the template

Release Notes

expressjs/express (express)

v4.20.0

Compare Source

==========

  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • add depth option to customize the depth level in the parser
    • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect
  • deps: [email protected]
    • Adds support for named matching groups in the routes using a regex
    • Adds backtracking protection to parameters without regexes defined
  • deps: encodeurl@~2.0.0
    • Removes encoding of \, |, and ^ to align better with URL spec
  • Deprecate passing options.maxAge and options.expires to res.clearCookie
    • Will be ignored in v5, clearCookie will set a cookie with an expires in the past to instruct clients to delete the cookie

v4.19.2

Compare Source

==========

  • Improved fix for open redirect allow list bypass

v4.19.1

Compare Source

==========

  • Allow passing non-strings to res.location with new encoding handling checks

v4.19.0

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 4 times, most recently from d4d6aa5 to 2ec6fac Compare April 6, 2024 21:37
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 3 times, most recently from e33c780 to c6aac9e Compare April 17, 2024 15:40
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 3 times, most recently from c99e97e to 41e34cd Compare April 26, 2024 06:29
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 5 times, most recently from 7d9e5b6 to ef76c54 Compare May 11, 2024 06:41
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from d2f2128 to b561e10 Compare May 16, 2024 14:12
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 3 times, most recently from 64d328e to 6c9180b Compare June 20, 2024 18:25
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from c47821f to 8012d73 Compare July 5, 2024 09:02
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 8012d73 to bd46e62 Compare July 11, 2024 01:08
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from bd46e62 to a5833bb Compare July 24, 2024 15:05
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from a5833bb to c3c2067 Compare August 6, 2024 17:37
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 5 times, most recently from 19d3f55 to 3714f15 Compare August 20, 2024 18:38
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 7 times, most recently from 1dc8be4 to 2031992 Compare October 28, 2024 17:05
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 2031992 to 31f0a84 Compare October 28, 2024 18:41
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 31f0a84 to 3ca41ff Compare November 5, 2024 19:56
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 5 times, most recently from e711cae to 3b220d2 Compare November 21, 2024 08:32
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from 75d688b to 9c97271 Compare November 25, 2024 18:46
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 9c97271 to b5d4be3 Compare November 30, 2024 17:40
@renovate renovate bot changed the title fix(deps): update dependency express to ~4.20.0 [security] Update dependency express to ~4.20.0 [SECURITY] Nov 30, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 9 times, most recently from cfb1894 to aaebd93 Compare December 5, 2024 19:23
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from aaebd93 to 0a15fcc Compare December 6, 2024 12:47
@renovate renovate bot changed the title Update dependency express to ~4.20.0 [SECURITY] fix(deps): update dependency express to ~4.20.0 [security] Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants